search

mwkwsd / sensensomething

3 stars 0 forks source link

Update to use modal everywher #109

Closed ChuckBTaylor closed 4 months ago

ChuckBTaylor commented 4 months ago

I'd only made the change to the video list. This updates so that all places where videos were now holds a modal placeholder.

Closes #92

netlify[bot] commented 4 months ago

Deploy Preview for kurt-sensenbrenner ready!

Name Link
Latest commit 122f1c22619ef2797e0f5e3f66b973b7c8ee9b5d
Latest deploy log https://app.netlify.com/sites/kurt-sensenbrenner/deploys/65e388152cd72b0008051aa7
Deploy Preview https://deploy-preview-109--kurt-sensenbrenner.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ChuckBTaylor commented 4 months ago

Can we add border/padding to the outside of this modal to make sure that it's closeable? Or just a close button? On mobile in portrait mode it's fine. But if you turn it to landscape you can't escape it.

I was just noticing the same. Talking with Vika, we'll add a small (48px) border to each side. Then add an X in the top right.

Can we create an issue for that and merge this in? #93 builds on top of this.