search

mwkwsd / sensensomething

3 stars 0 forks source link

Add border to landscape modal view #110

Open ChuckBTaylor opened 4 months ago

ChuckBTaylor commented 4 months ago

Talking with Vika, we'll add a small (48px) border to each side. Then add an X in the top right.

X should be in a box that is 44px on a side. X should be 32px (2rem)

Originally posted by @ChuckBTaylor in https://github.com/mwkwsd/sensensomething/issues/109#issuecomment-1962289539

mwilkins74 commented 4 months ago

Do we want a specific color on this border? Otherwise, it'll be "invisible".

mwilkins74 commented 4 months ago

Also, 48px is pretty large. I put a red 48px border in just to show the size:

Screen Shot 2024-02-26 at 10 21 17 AM
ChuckBTaylor commented 4 months ago

Do a 48px border on the x axis when the mobile is landscape mode. What does that look like?

mwilkins74 commented 4 months ago

In order to make the border appear on the x-axis I had to decrease the width of the Card from 100% to 80%.

Screen Shot 2024-03-04 at 8 45 20 AM
ChuckBTaylor commented 3 months ago

This is what she's looking for.