mwkwsd / sensensomething

3 stars 0 forks source link

Started building/styling the Header #17

Closed mwilkins74 closed 7 months ago

mwilkins74 commented 8 months ago

Started building and styling the Header since it is pretty much static across the application. Font-size dynamically changes between Mobile and Desktop. Can add Hamburger once #6 is merged in.

I then re-wrote the Header Component to utilize the Styled Component thing from MUI. It looks very clunky so I left all of the CSS I previously wrote in App.css but just commented it out. That way if we decide we like one over the other we just delete what we don't want and use what we do.

Screen Shot 2024-01-08 at 10 37 05 AM
mwilkins74 commented 8 months ago

Not sure if it'll be re-usable, but a more generic naming convention is definitely not a bad idea.

ChuckBTaylor commented 7 months ago

Those aren't the links we want to send them to. We want to send them to like /video-list?filter=documentary or something

Or did we go with another navigation?

Either way, we don't want white space in the url.

mwilkins74 commented 7 months ago

Is this comment on the wrong PR?

ChuckBTaylor commented 7 months ago

I wondered where that went. Yup.

mwilkins74 commented 7 months ago

Lol!

I won't get to this till probably Tuesday afternoon so if one of you guys wants to snag this and do it feel free. I definitely will have some learning to do to finish this up.

mwilkins74 commented 7 months ago

Is this ready to be merged in?

mwilkins74 commented 7 months ago

Ok, I wasn't touching styling cause we were focusing more on functionality first. And, also I had styling done, then we started alternating to ThemeProvider. I can work on styling this week or we can merge in, get the Header in place then style from there?

ChuckBTaylor commented 7 months ago

Oh, by styling I meant formatting. Sorry. Not quite with it this monring. Don't actually care about styling

mwilkins74 commented 7 months ago

Gotcha. I'll update my prettier and get it reformatted. I'm over here getting all confused lol

ChuckBTaylor commented 7 months ago

Sorry about that, @mwilkins74 , I merged in the theme stuff I did and it sprang some conflicts on you

mwilkins74 commented 7 months ago

How dare you!!! All good. There's been rebases and merge conflicts for weeks now.