search

mwkwsd / sensensomething

3 stars 0 forks source link

NavBar and React Routing brought together. Styling tackled. #19

Closed mwilkins74 closed 7 months ago

mwilkins74 commented 8 months ago

Navigation handled by bringing NavBar/NavList and React Routing together. Tackled styling too! Clicking on a Link highlights the Link in the (currently) light grey div.

Screen Shot 2024-01-09 at 5 25 32 PM
mwilkins74 commented 7 months ago

Still working on that last commit (aka draft). Wanted to commit it my current work just in case I don't get it completed today and don't touch till next week.

mwilkins74 commented 7 months ago

Ok, Navigation Buttons have been all pulled out of NavList and restructured. It is super messy as they are all in their own files right now as atoms. Will absolutely help to utilize the enum stuff here to clean all this up. That will be a next week task for me at least.

mwilkins74 commented 7 months ago

Pulled apart NavList and made it more concise. I made a NavLinks component to contain Recent Work, About, and Contact and a SubheaderList component for Roles and Genres. (Now that I'm typing them the names of these components need changing). I couldn't figure out how to do one component for all of the above Links, but this is much cleaner so I am sending it up for starting to piece the app together and moving forward.

Styling will also need fixing but we all know that.

mwilkins74 commented 7 months ago

Sure! That was my intention. Get it better than it was, merge it in, and keep moving forward.

mwilkins74 commented 7 months ago

I will merge this in now. Then would love to see/some guidance on how to make this even more intelligently written.