Hook up email JS - Githubissues

mwkwsd / sensensomething

3 stars 0 forks source link

Hook up email JS #34

Open ChuckBTaylor opened 8 months ago

kmdunn5 commented 8 months ago

Do we want these tokens as environment variables?

mwilkins74 commented 8 months ago

Might not be a bad idea.

ChuckBTaylor commented 8 months ago

What does our deployment service suggest for keys? @mwilkins74 you've used them before.

kmdunn5 commented 8 months ago

I have it hooked up and emailing. I'm using env variables currently, but that will just mean we have to make sure we pass those into the deploy. There's a public token, a template token, and a service token. I think at least the service should stay hidden. So I just went with all of them.

mwilkins74 commented 8 months ago

Netlify (if that's the deployment service we go with) does work with a netlify.toml file in which environment variables can be stored and are "picked" up during deployment.

https://docs.netlify.com/configure-builds/file-based-configuration/

kmdunn5 commented 7 months ago

netlify env vars

kmdunn5 commented 6 months ago

@ChuckBTaylor and @mwilkins74

Thinking about punting on this and just hard coding them in. Not great practice, but seems like we either do that or pay for netlify. Thoughts?

ChuckBTaylor commented 6 months ago

I guess we ask Kurt what he wants to do. He'd be the one paying (in either case) after all.

mwilkins74 commented 6 months ago

For sure. We can bring up to him whenever we set up a "here's your website" call.