search

mwood77 / pf2opn

An in-browser pfsense to opnsense converter.
https://www.pf2opn.com
Other
88 stars 7 forks source link

Firewall alias section broken #21

Closed madscientist159 closed 5 months ago

madscientist159 commented 5 months ago

The entire alias section of the firewall configuration seems to be unparsed / not updated.

What it should be:

          <alias uuid="72b6208b-e50d-4d68-a594-da0fa6760000">
            <enabled>1</enabled>
            <name>MY_HOST</name>
            <type>host</type>
            <proto/>
            <interface/>
            <counters>0</counters>
            <updatefreq/>
            <content>19192.168.1.1</content>
            <categories/>
            <description>Entry added Mon, 01 Jan 1979 01:23:45 -0000</description>
          </alias>

What comes out:

    <alias>
      <name>MY_HOST</name>
      <type>host</type>
      <address>192.168.1.1</address>
      <descr></descr>
      <detail>Entry added Mon, 01 Jan 1979 01:23:45 -0000</detail>
    </alias>
mwood77 commented 5 months ago

Good to know - i'll look into this over the weekend.

The CDATA #20 might take more time to track down though.

madscientist159 commented 5 months ago

Since we run OPNsense at an enterprise level I figured our configuration would probably give this tool a good workout. I'll be filing bugs here and there for specific issues I ran into; for CDATA we have an internal means to deal with it at the moment but that's definitely not something that's ever getting released :wink:

Appreciate you tackling the long-standing problem of having to reenter all data by hand when migrating to OPNsense! It's not a trivial task...

mwood77 commented 5 months ago

This has been addressed in #23 ; closing. If issues persist, please re-open.