search

mwootendev / ngx-translate-plugins

Utilities plugins for the @ngx-translate translation library.
MIT License
16 stars 10 forks source link

Using require() instead of import #5

Closed azollai closed 4 years ago

azollai commented 5 years ago

Is there a specific reason why you are using require() and not import? E.g. import * as translation from '../../i18n/hu.json';

TranslateTestingModule.withTranslations(ENGLISH_LANGUAGE, ENGLISH_TRANSLATIONS)
  .withTranslations(SPANISH_LANGUAGE, SPANISH_TRANSLATIONS)
  .withTranslations(ENGLISH_LANGUAGE, require('../../assets/i18n/en.json'))
mwootendev commented 5 years ago

The original version was written against Angular 6 with TypeScript 2.7, which at the time did not support that feature.