search

mworion / MountWizzard4

Amateur astronomy imaging support tool with special support for 10micron mounts.
Apache License 2.0
23 stars 8 forks source link

Satellite Module: float division by zero #30

Closed Ruediger3 closed 4 years ago

Ruediger3 commented 4 years ago

When selecting database and and object a 'Division by Zero' is thrown in cmd window. See screen shots. Active.txt and visuals.txt get updated and contain valid data. They are also attached.

2020-05-22_15h23_16 2020-05-22_15h24_47 2020-05-22_15h24_53 active.txt visual.txt

mworion commented 4 years ago

Rüdiger,

I think I found the problem: Your PC is set to German, right ? The library has a problem parsing the TLE strings when not set to English. If you could give it a try, you're welcome, but I wait now for the response of Brandon, who is maintainer of the skyfield package.

Michel

Ruediger3 commented 4 years ago

Hi Michel, yes, you were right! Switching to US solved it, but this is no persistent solution, since all the other applications do not work anymore :( 2020-05-22_16h13_45

Ruediger3 commented 4 years ago

Hi Michel, 0.150.17b1 works with German separator. Thank you!

mworion commented 4 years ago

I built a 0.150.17b1, which should be able to run with German setting. It would be nice to give it a try. Michel

mworion commented 4 years ago

Actually reproducible.

Ruediger3 commented 4 years ago

Are you sure about 17b since we have been already at 20b? Not visible for installation yet

2020-05-28_18h12_51

mworion commented 4 years ago

Hi Rüdiger, are you willing to make a counter test now ? if so please go to the non functioning v0.150.20. Check if it's still broken. Close MW4. Open power shell goto your work directory go to virtual environment with command:

venv/Scripts/activate

install new library with command

pip install https://github.com/brandon-rhodes/python-sgp4/archive/master.zip

close powershell and start MW4 v0.150.20 again. This should do the trick.

Please let me know if you do so. Michel

Ruediger3 commented 4 years ago

Hi Michel, I can confirm this works. I had to manually install sgp4. Do I have to do manually install SGP anytime I install an update?

Thanks Rüdiger

BTW: there is also an issue with the first pass. It is always in the past (red box)

2020-05-28_19h37_08

mworion commented 4 years ago

Thanks for testing, Brandon will release the new library when we sign it off (what we will do now). from That point on I will release 0.150.21. Then it's done. I've seen the point with the first pass. I played around. I this version I will have a better selection ! Michel

Ruediger3 commented 4 years ago

Thanks Michel for your great support!