search

mwouts / itables

Pandas DataFrames as Interactive DataTables
https://mwouts.github.io/itables/
MIT License
757 stars 56 forks source link

add safety in case pandas display.max_columns is None #15

Closed artdgn closed 3 years ago

artdgn commented 3 years ago

resolves https://github.com/mwouts/itables/issues/14

codecov-commenter commented 3 years ago

Codecov Report

Merging #15 into master will increase coverage by 0.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   96.58%   96.77%   +0.18%     
==========================================
  Files           9       10       +1     
  Lines         205      217      +12     
==========================================
+ Hits          198      210      +12     
  Misses          7        7
Impacted Files Coverage Δ
itables/javascript.py 92.68% <100.00%> (ø)
tests/test_javascript.py 100.00% <100.00%> (ø)
tests/test_downsample.py 100.00% <0.00%> (ø)
tests/test_notebooks.py 96.87% <0.00%> (+0.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2617bed...abd8a20. Read the comment docs.

artdgn commented 3 years ago

CI for 3.4 fails with:

PyYAML requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*' but the running Python is 3.4.8

The command "pip install -r requirements-dev.txt" failed and exited with 1 during

It looks like the current versions of the dependencies don't work with Python 3.4, so I guess there are two options:

  1. Drop support for 3.4 and remove it from Yaml file
  2. Pin dependencies to older versions.

Will add a commit removing 3.4 some time later.

mwouts commented 3 years ago

Thank you @artdgn , that is really awesome... a fix, a unit test, and a fix of the CI ! I'll try to ship the new release tonight.

artdgn commented 3 years ago

@mwouts thanks!

Also thanks for jupytext, a super helpful tool!