fwouts
commented
1 year ago I suspect the problem is that <script type="module"> code isn't evaluated immediately like <script>, it's automatically deferred (like <script type="module" defer>). It appears that cannot be disabled.
You can see an example with the following file:
<!DOCTYPE html>
<html>
<body>
<script>
console.log("Hello from regular script 1");
</script>
<script type="module">
console.log("Hello from module");
</script>
<script>
console.log("Hello from regular script 2");
</script>
</body>
</html>The output here (in Chrome at least) is:
Hello from regular script 1
Hello from regular script 2
Hello from moduleHowever as far as I understand, a deferred script is still guaranteed to run before $(document).ready() (which I believe is equivalent to the browser's native DOMContentLoaded event), so I'm not sure why it's possible to get this bug in the first place!
I've attempted to fix this in https://github.com/mwouts/itables/compare/catch_retry...fwouts:itables:catch_retry by using a promise. I haven't tested this code though, as I'm not sure how to do that :) There could be a bug or two in there.
Is there a contributing guide somewhere?
mwouts
codecov-commenter
Sometimes when a notebook is reloaded from disk, the tables don't load, and in the console I find a message window.initializeDataTables is not a function.
This PR intends to postpone the table initialization when this occur, to let some time for the init script to load (that script is located in another section of the HTML document).
@fwouts , do you see a better approach? Ideally I would declare a dependency of (the rendered version of)
datatables_template.htmlon (the rendered version of)initialize_offline_datatable.htmlbut I have not idea how to do that...