mwouts / itables

Pandas DataFrames as Interactive DataTables
https://mwouts.github.io/itables/
MIT License
715 stars 53 forks source link

1.7.0 removes default grid styling present in < 1.7.0 #229

Closed cpcloud closed 3 months ago

cpcloud commented 4 months ago

Here's a rendered table from a local build of the Ibis website's operation support matrix (https://ibis-project.org/support_matrix) using 1.6.4: image

With 1.7.0:

image

mwouts commented 4 months ago

Do you think this might be caused by the move of the style inside the div?

image

Cf. https://github.com/mwouts/itables/compare/v1.6.4...v1.7.0

If I were to revert this change in a branch, would you be able to install it locally for testing?

cpcloud commented 4 months ago

Yep, I can give it a try locally

mwouts commented 4 months ago

Ok great! Can you try this version then?

pip install git+https://github.com/mwouts/itables.git@revert_style

Thanks

mwouts commented 4 months ago

Hey @cpcloud , have you been able to give a try at the above? Thanks!

cpcloud commented 4 months ago

Yep, unfortunately it didn't seem to help.

mwouts commented 4 months ago

I see. Do you think you could share a minimal example that I could run on my end?

mwouts commented 3 months ago

Hi @cpcloud , would you mind giving a try at itables==2.0? I'd be curious to know if the issue is resolved now.

cpcloud commented 3 months ago

@mwouts Looks good with itables==2.0! Thanks!

image

mwouts commented 3 months ago

Awesome! Thanks for letting me know!