Offline mode by default

[mwouts]

This is the result of a pair coding session with @fwouts .

We'd like to

• Use inline javascript by default (i.e. the jQuery and datatables libraries are injected in the notebook, so there's no need to be online)
• Allow the user to use his own urls if they prefers to do so (the inline mode increases the size of each notebook by about 700kB)

TODO

• [x] Make sure this works in all environments (Jupyter Lab, Jupyter Notebook, NBconvert, Jupyter Book, VS Code, PyCharm) for both inline=True/False
• [x] Make sure this works reliably (new notebook, notebook executed and reloaded, notebook executed, reloaded and re-executed)

[codecov-commenter]

Codecov Report

Merging #77 (76ac274) into main (2862a8b) will decrease coverage by 1.15%. The diff coverage is 89.65%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   96.66%   95.51%   -1.16%     
==========================================
  Files          14       16       +2     
  Lines         330      379      +49     
==========================================
+ Hits          319      362      +43     
- Misses         11       17       +6     

Impacted Files	Coverage Δ
itables/javascript.py	92.75% <77.77%> (-3.89%)	:arrow_down:
itables/version.py	100.00% <100.00%> (ø)
tests/test_changelog.py	100.00% <100.00%> (ø)
tests/test_connected_notebook_is_small.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2862a8b...76ac274. Read the comment docs.

[lgtm-com[bot]]

This pull request introduces 49 alerts when merging 026315ccf366f18b6216606c8433fc5ccc2f4d21 into 2862a8be209b309a222d32fab1509c62b17a0d49 - view on LGTM.com

new alerts:

• 34 for Unused variable, import, function or class
• 5 for Incomplete multi-character sanitization
• 2 for Useless assignment to local variable
• 2 for Superfluous trailing arguments
• 2 for Incomplete string escaping or encoding
• 1 for Useless conditional
• 1 for Comparison between inconvertible types
• 1 for Duplicate character in character class
• 1 for Unneeded defensive code

[lgtm-com[bot]]

This pull request introduces 49 alerts when merging c7d9f0c510c20bfdff8532b24df83230e8c2996d into 2862a8be209b309a222d32fab1509c62b17a0d49 - view on LGTM.com

new alerts:

• 34 for Unused variable, import, function or class
• 5 for Incomplete multi-character sanitization
• 2 for Useless assignment to local variable
• 2 for Superfluous trailing arguments
• 2 for Incomplete string escaping or encoding
• 1 for Useless conditional
• 1 for Comparison between inconvertible types
• 1 for Duplicate character in character class
• 1 for Unneeded defensive code

[lgtm-com[bot]]

This pull request introduces 49 alerts when merging 44633c4c9314b1ca334908b71fe19a06ca7bdad2 into 2862a8be209b309a222d32fab1509c62b17a0d49 - view on LGTM.com

new alerts:

• 34 for Unused variable, import, function or class
• 5 for Incomplete multi-character sanitization
• 2 for Useless assignment to local variable
• 2 for Superfluous trailing arguments
• 2 for Incomplete string escaping or encoding
• 1 for Useless conditional
• 1 for Comparison between inconvertible types
• 1 for Duplicate character in character class
• 1 for Unneeded defensive code

[lgtm-com[bot]]

This pull request introduces 49 alerts when merging a074cfa7961640640a22e9e70f104b2ec0bf6e82 into 2862a8be209b309a222d32fab1509c62b17a0d49 - view on LGTM.com

new alerts:

• 34 for Unused variable, import, function or class
• 5 for Incomplete multi-character sanitization
• 2 for Useless assignment to local variable
• 2 for Superfluous trailing arguments
• 2 for Incomplete string escaping or encoding
• 1 for Useless conditional
• 1 for Comparison between inconvertible types
• 1 for Duplicate character in character class
• 1 for Unneeded defensive code

[mwouts]

The "connected=True" mode seems to work in every environment.

The (new) "connected=False" mode works well in Jupyter Lab and Notebook. It also seems to work in VS Code. In PyCharm the reload of a "connected=False" notebook fails to display the table. In Colab the table is not displayed, even in a fresh notebook... (https://colab.research.google.com/drive/1JPZIasTiH3rIUysDr3eWDz4jgTTq00aq?usp=sharing#scrollTo=ia5E-zUo055L) The difficulty with these environments is that I don't really know how to see the browser logs...

[lgtm-com[bot]]

This pull request introduces 1 alert when merging 23f79c5834812c8540d767261db000aa17ed9b5b into 2862a8be209b309a222d32fab1509c62b17a0d49 - view on LGTM.com

new alerts:

• 1 for Unused import

[lgtm-com[bot]]

This pull request introduces 1 alert when merging db60c785c61da02378fffa000d3eb69739dee8b4 into 2862a8be209b309a222d32fab1509c62b17a0d49 - view on LGTM.com

new alerts:

• 1 for Unused import

[lgtm-com[bot]]

This pull request introduces 1 alert when merging c5d81cc2596e3ebb123e14942587025015d4cad1 into 2862a8be209b309a222d32fab1509c62b17a0d49 - view on LGTM.com

new alerts:

• 1 for Unused import