search

mwouts / itables

Pandas DataFrames as Interactive DataTables
https://mwouts.github.io/itables/
MIT License
771 stars 56 forks source link

Use a dynamic import to ensure we await it #78

Closed fwouts closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #78 (bccd044) into inline_mode (44633c4) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff              @@
##           inline_mode      #78   +/-   ##
============================================
  Coverage        95.82%   95.82%           
============================================
  Files               15       15           
  Lines              359      359           
============================================
  Hits               344      344           
  Misses              15       15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44633c4...bccd044. Read the comment docs.

mwouts commented 2 years ago

Oh I see! Thanks @fwouts

mwouts commented 2 years ago

I confirm that with that commit the notebook still works after a "reload" in Jupyter Lab

mwouts commented 2 years ago

The "reload" also worked in Jupyter Notebook, even with "inline=False". There's a little problem remaining, with "inline=False" in Jupyter Lab the reload does not work... I see this error: Uncaught ReferenceError: $ is not defined