Closed mahendrapaipuri closed 1 year ago
@LecrisUT Cheers for the review!! I will wait for @mwouts as well before making any further changes, if that is ok.
Hi @mahendrapaipuri , @LecrisUT , I am sorry I have too little time tonight to review this in more details, I'll do more tomorrow.
Is the local build supposed to work with just python -m build
? Locally it fails with this message:
OSError: Error getting the version from source `regex`: file does not exist: src/jupytext/version.py
(but the file does exist)
Thanks again for making this happen!
Is the local build supposed to work with just
python -m build
? Locally it fails with this message:OSError: Error getting the version from source `regex`: file does not exist: src/jupytext/version.py
Yes, that's the intended interface. Not sure what's causing the error. I can help debug this issue in the weekend if it persists.
Closed in favour of #1140
@mwouts @LecrisUT Lets move the discussion to #1140
This PR attempts to reorganize repo to
src-layout
, migrate the package to hatch build system which is being used in the Jupyter ecosystem and also address PEP621 by moving all the package metadata topyproject.toml
.New organization:
Only important folders are listed in the tree
Breaking changes:
src-layout
to put all core modules ofjupytext
insrc/
folderjupytext_config
has been created with same behaviour asjupytext-config
console scriptjupyterlab_jupytext
has been moved intojupyterlab/
folder including all jupyter related config files.jupyterlab_jupytext
will be distributed as another python module along withjupytext
,jupytext_config
. All thejupyter_server
andjupyterlab
related extension registration has been moved intojupyterlab_jupytext
module.HATCH_BUILD_HOOKS_ENABLE=true
env var instead of currentBUILD_JUPYTERLAB_EXTENSION=1
env var for local dev.TLDR; Instead of distrtributing a single
jupytext
package (which is the current case now), we split it into threejupytext
(core),jupytext_config
(config) andjupyterlab_jupytext
(Jupyter server and lab extension). Building of labextension is disabled by default and we can enable it usingHATCH_BUILD_HOOKS_ENABLE=true
env var passed atpip install .
List of changes:
3.8
inline with JupyterLab 4sphinx-gallery
dependency has been removedpyproject.toml
tox
config has been removedcheck-release.yml
workflow from jupyter-releaserMisc:
I have added
check-release.yml
workflow from jupyter-releaser just to check if it works with the current organisation. If you are keen to move tojupyter-releaser
, the workflow would be to manually bump the versions in a PR and then use prep-release and publish-release workflows which will publish python and npm packages.Current organization does not let us to publish
npm
packages fromjupyter-releaser
. If we movejupyterlab/package.json
and its auxillary config files to the root of the top, we can build and publishnpm
packages fromjupyter-releaser
workflows as well.Todo:
Closes #1076 Closes #1114 Closes #1115 Closes #1135