mwouts / jupytext

Jupyter Notebooks as Markdown Documents, Julia, Python or R scripts
https://jupytext.readthedocs.io
MIT License
6.6k stars 386 forks source link

Split tests into `unit`, `integration`, `functional` #1136

Closed LecrisUT closed 10 months ago

LecrisUT commented 11 months ago

It is a rather organizational change, but for those familiar with the concepts, it helps them find the tests easier and to know what to expect:

mwouts commented 10 months ago

Hi @LecrisUT , I plan to work on this in the coming days. Would you have an example repo that follows that organisation? I see https://realpython.com/python-testing/#writing-integration-tests , is there any other reference that you'd like me to have a look to?

To be sure of what you expect here, is it fine if I follow e.g. and move the current tests under a series of folders like e.g. unit, functional\cli, functional\contents_manager, integration\pre-commit, and maybe move a few tests under external for the tests that mostly test the compatibility with external packages?

LecrisUT commented 10 months ago

Here's an example: https://github.com/packit/packit/.

move the current tests under a series of folders like e.g. unit, functional\cli, functional\contents_manager, integration\pre-commit, and maybe move a few tests under external

Yes, that about sums it. Just make sure there are corresponding marks as well

I'll have some time next weekend as well

mwouts commented 10 months ago

@LecrisUT , @mahendrapaipuri , I am not able to add you as reviewers to #1155, but I think it's getting ready. Would you like to have a look and let me know what you think?

mahendrapaipuri commented 10 months ago

Sure @mwouts! I will take a look at the patch this week.