mwouts / jupytext

Jupyter Notebooks as Markdown Documents, Julia, Python or R scripts
https://jupytext.readthedocs.io
MIT License
6.6k stars 386 forks source link

Reorganize the tests into unit/functional/integration/external #1155

Closed mwouts closed 10 months ago

mwouts commented 10 months ago

This is very much a work in progress for now. I'll try to classify all the different tests. Will close #1136.

codecov[bot] commented 10 months ago

Codecov Report

Merging #1155 (3fcc046) into main (4b56512) will increase coverage by 1.96%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   93.12%   95.08%   +1.96%     
==========================================
  Files          29       29              
  Lines        4419     4418       -1     
==========================================
+ Hits         4115     4201      +86     
+ Misses        304      217      -87     
Files Coverage Δ
src/jupytext/parse_version.py 100.00% <100.00%> (+80.00%) :arrow_up:

... and 10 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

mwouts commented 10 months ago

Hi @LecrisUT , were you thinking of something like the current PR? You also suggested to add pytest markers I guess? And maybe it would be good to check that the test dependencies I have described at https://github.com/mwouts/jupytext/pull/1155/commits/30bd073d44b5f241c312da509b2e04afa2b122d6 are indeed correct - is this something you expect to see on the CI in some way?

LecrisUT commented 10 months ago

Sorry, had a long week, I have a few notes, let me get to my PC later today and I'll write them out

mwouts commented 10 months ago

No worries at all! Take your time! This can as well be later on this week or next week-end. Thanks!

LecrisUT commented 10 months ago

About the conda test failure, it seems you need to add a browser in the relevant packages.json

mwouts commented 10 months ago

Thanks @LecrisUT for guiding me into this! I am very glad with the outcome.

I've set up the coverage flags: image

Also the coverage seems to go up (but I would like to see codecov commenting on this PR too!) image

Also, remind me to make a PR to re-organize these CI files.

Thanks, they are all yours!

mwouts commented 10 months ago

@kloczek I know from #906 that the tests/packaging matter to you. We have recently changed both the packaging and the tests, would you mind to have a look and let us know if everything seems alright to you?

kloczek commented 10 months ago

@kloczek I know from #906 that the tests/packaging matter to you. We have recently changed both the packaging and the tests, would you mind to have a look and let us know if everything seems alright to you?

No problem. 😄 Jut please let me know what you want to me to test?