mwouts / jupytext

Jupyter Notebooks as Markdown Documents, Julia, Python or R scripts
https://jupytext.readthedocs.io
MIT License
6.65k stars 386 forks source link

a couple obvious tweaks #1166

Closed parmentelat closed 11 months ago

parmentelat commented 11 months ago

in main we have

at first I tried to file this PR against @mahendrapaipuri's current branch lang_specific_text_nb but could not find their fork so, here it goes..

mahendrapaipuri commented 11 months ago

@parmentelat Cheers for fixing typos!

Seems like due #1165 all CI tests are failing.

mwouts commented 11 months ago

Seems like due #1165 all CI tests are failing.

This should be fixed now (following #1173) - let me rebase this PR...

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e1c6d13) 97.59% compared to head (4a36727) 97.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1166 +/- ## ======================================= Coverage 97.59% 97.59% ======================================= Files 26 26 Lines 4357 4357 ======================================= Hits 4252 4252 Misses 105 105 ``` | [Flag](https://app.codecov.io/gh/mwouts/jupytext/pull/1166/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | Coverage Δ | | |---|---|---| | [external](https://app.codecov.io/gh/mwouts/jupytext/pull/1166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | `75.23% <ø> (+0.11%)` | :arrow_up: | | [functional](https://app.codecov.io/gh/mwouts/jupytext/pull/1166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | `88.54% <ø> (ø)` | | | [integration](https://app.codecov.io/gh/mwouts/jupytext/pull/1166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | `76.84% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/mwouts/jupytext/pull/1166/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | `66.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mahendrapaipuri commented 11 months ago

@mwouts Dont bother to work on this PR anymore. This is obsolete based on new commits in #1163