Closed mwouts closed 10 months ago
Hi @LecrisUT , I have done some research on this, and apparently, it is not possible to get a green tick on the commit when one of the experimental jobs fails. Do you mind if I remove them for now ? Thanks!
Yes, that's one of the big annoyance with github actions. There is the all-greens action that will tell you the "true" state of the CI. But that will still show a cross on the commit itself, so yeah, can go ahead an disable them.
One thing I haven't experimented is how does the CI look on scheduled builds. If that works, i.e. it is not reported, we could limit those jobs within PRs and schedules. That does mean that all of the other commits in the history will get re cross except for the merge commit.
Thank you @LecrisUT for your understanding ! By the way I am thinking of adding a --pre run for the CI, hopefully that one will most often work!
@mwouts can you re-open this issue? I think I've found a design for this:
https://stackoverflow.com/a/75987914
The plan there is after #1190, the experimental jobs will have that step included to make the CI look green on the main
branch, while in the PR it will still report like normal
@mwouts I found the proper solution for now: https://github.com/LecrisUT/CMake-Template/pull/7
You can see there that in the PR the checks are still red, but on the main
branch they're all green. In this case it was possible because I know the failing tests come from a specific step.
Some of the CI builds are allowed to fail, but apparently when they fail (and they always do since we test future versions), we get a red cross on the commit, like here: