Closed mahendrapaipuri closed 10 months ago
Thank you for making this pull request.
Did you know? You can try it on Binder: or .
Also, the version of Jupytext developed in this PR can be installed with pip
:
pip install git+https://github.com/mahendrapaipuri/jupytext.git@viewer_for_generic_languages
(this requires nodejs
, see more at Developing Jupytext)
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7223622
) 97.73% compared to head (8866366
) 97.73%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @mahendrapaipuri ! Just tested and it works like a charm. Now I have the 'bash' type for documents (screenshot below) and adding it to the Jupytext viewer let me open it as a notebook with a single click.
I think most MyST users prefer to use .md
as the file extension, because it's mostly Markdown, and this way you can get it rendered as such on GitHub, etc.
Current implementation will open markdown, myst, Rmd and qmd formats as notebooks by default. Is it intended? I m asking because this was the behaviour in 1.15.x and I have not changed it.
I think this is specific to Binder (which we configure in this way). Let me have a look.
Current implementation will open markdown, myst, Rmd and qmd formats as notebooks by default. Is it intended? I m asking because this was the behaviour in 1.15.x and I have not changed it. I guess you would like the markdown variants open as text files by default and able to change them as notebooks by overriding default viewers
Well you're right! Well I'd say that we let this as such (nobody complained about this, plus the notebook editor does look very similar to the markdown viewer for markdown files). Thanks for pointing this out
Fixes #1164
Now users can configure default Viewers for docManager to open them as Notebooks. By default text notebooks will always open as file with editor factory.
@parmentelat @mwouts Could you please test the patch and see if it is the desired behaviour? Current implementation will open markdown, myst, Rmd and qmd formats as notebooks by default. Is it intended? I m asking because this was the behaviour in
1.15.x
and I have not changed it. I guess you would like the markdown variants open as text files by default and able to change them as notebooks by overriding default viewers. If so, let me know, I will make necessary changes.@mwouts What is the reason of choosing format as
md:myst
for MyST? I have noticed that creating a MyST text notebook creates the file with.md
extension. Is it not supposed to be created with.myst
extension? If so, we need to change the format tomyst
.Cheers!!