mwouts / jupytext

Jupyter Notebooks as Markdown Documents, Julia, Python or R scripts
https://jupytext.readthedocs.io
MIT License
6.65k stars 386 forks source link

Add language support for Lua #1252

Closed erentar closed 4 months ago

erentar commented 4 months ago

I have tried my best in following the instructions however was unable to get pip install -e '.[dev]' to work.

I would be thankful if someone helped me out by providing a dockerfile such that i can test it in a reproducible environment

github-actions[bot] commented 4 months ago

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/erentar/jupytext.git@testing

(this requires nodejs, see more at Developing Jupytext)

mwouts commented 4 months ago

Hi @erentar , thank you for making this PR! I am sorry that I can't provide a dockerfile, but I can provide conda instructions, see here: https://github.com/mwouts/jupytext/blob/main/docs/developing.md#install-and-develop-jupytext-locally

If you prefer I can also take your PR from here. Thanks!

erentar commented 4 months ago

@mwouts Please take over. I cannot get pytest to work.

mwouts commented 4 months ago

@mwouts Please take over. I cannot get pytest to work.

No problem! I'll get this done, and we will have the Lua support in the next release. Thank you for your contribution!

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.73%. Comparing base (42a48e8) to head (bc8c4a8). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1252 +/- ## ======================================= Coverage 97.73% 97.73% ======================================= Files 29 29 Lines 4468 4468 ======================================= Hits 4367 4367 Misses 101 101 ``` | [Flag](https://app.codecov.io/gh/mwouts/jupytext/pull/1252/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | Coverage Δ | | |---|---|---| | [external](https://app.codecov.io/gh/mwouts/jupytext/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | `75.14% <ø> (+0.09%)` | :arrow_up: | | [functional](https://app.codecov.io/gh/mwouts/jupytext/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | `88.52% <ø> (ø)` | | | [integration](https://app.codecov.io/gh/mwouts/jupytext/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | `77.28% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/mwouts/jupytext/pull/1252/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts) | `66.56% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Wouts#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.