search

mwouts / jupytext

Jupyter Notebooks as Markdown Documents, Julia, Python or R scripts
https://jupytext.readthedocs.io
MIT License
6.65k stars 386 forks source link

Jupytext's MyBinder link is broken #559

Closed mwouts closed 4 years ago

mwouts commented 4 years ago

The MyBinder launch fails. Apparently it's trying to parse jupytext.py as a configuration file when converting the get_started.md notebook :smile: Screenshot from 2020-07-06 22-06-19

mgeier commented 4 years ago

It still doesn't seem to work, I'm still getting the same error: https://mybinder.org/v2/gh/mwouts/jupytext/master?urlpath=lab/tree/demo/get_started.ipynb

mwouts commented 4 years ago

Hi @mgeier , I think this is because of the cache - as I don't have an explicit requirement for jupytext>=1.5.2 in binder/requirements.txt, MyBinder was still using the version 1.5.1 for some time.

On my side I now see it working at https://notebooks.gesis.org/binder/jupyter/user/mwouts-jupytext-jv21wl2s/lab . Is (the beginning of) your URL different? I mean, do you hit a different server with a different cache than mine?

mgeier commented 4 years ago

Oh, interesting!

I don't even get an URL, because the build is not successful.

I think you shouldn't put jupytext into the requirements.txt at all, you should make a "dev" install in postBuild. Then such problems cannot occur.

mwouts commented 4 years ago

Good idea! I'll do that.

mgeier commented 4 years ago

Thanks, now it works perfectly!

mwouts commented 4 years ago

Excellent! And thank you for keeping an eye this, Matthias.