search

mwpastore / ember-cli-deploy-sql

Deploy your Ember.js index to a database table
MIT License
8 stars 3 forks source link

Return [] from listRevisions when no table exists #1

Closed rlivsey closed 7 years ago

rlivsey commented 7 years ago

listRevisions runs before we’ve had a chance to setup the table on the first deploy and so fails.

This lets it return successfully so that the table can be setup later in the deploy.

Alternatively we could conditionally create the table?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.07%) to 97.661% when pulling 9a1cc0ba389b2f81b3dff84e561501f5195acce2 on rlivsey:list-revisions-when-not-yet-setup into f94a5e10065860ae7378b62cbebd4ca410947ed8 on mwpastore:master.

mwpastore commented 7 years ago

This would have been fine, but I realized that many of the other hooks will fail as well if the table isn't set up, so I went ahead and added a setup pipeline hook and moved the conditionallyCreateTable logic there. Thank you taking a whack at it!

rlivsey commented 7 years ago

:+1: makes much more sense