mwpennell / arbutus

Assessing the adequacy of phylogenetic models of quantitative trait evolution
7 stars 2 forks source link

ordering of data #18

Closed mwpennell closed 8 years ago

mwpennell commented 9 years ago

a user was using arbutus and came across the following problem

in geiger (and some other packages, e.g., bayou), the order of tip labels and data do not need to be the same. so the returned object may not have them ordered according to the tip labels.

however, we do strict checking when creating the unit.tree (function check.tree.data)

    if (!identical(names(data), phy$tip.label)) 
        stop("Trait data and species do not align")

we do this b/c pic does not check. so my questions is: where should we do the reordering? when getting the info from model objects or just prior to computing the pics? each will require modifications to the tests