search

mwpennell / arbutus

Assessing the adequacy of phylogenetic models of quantitative trait evolution
7 stars 2 forks source link

CRAN? #23

Open mwpennell opened 8 years ago

mwpennell commented 8 years ago

hey @richfitz i was thinking today that it might be nice to move arbutus to CRAN at some point. However, it will fail -- harshly -- if we send it there. the problem is that some of the functions require() diversitree, geiger, etc., etc. and use internal functions from these. and the CRAN version of geiger still launches a bunch of cores which causes its own problems...

richfitz commented 8 years ago

I don't see any internal functions being used (a quick check for ":::" in R/) so we're OK there. The require functions can be replaced with requireNamespace and some tweaking done. Will have a quick look into this now.

richfitz commented 8 years ago

OK, over to you for the geiger issue. I don't see many other difficult things in the check after doing bfaba4f

mwpennell commented 8 years ago

Great. thanks so much. Working on the geiger thing right now.

richfitz commented 8 years ago

Don't forget to run the checks with --as-cran, which is disabled in the makefile.

mwpennell commented 8 years ago

Thanks for the heads up. Somehow I did remember this.

On Wed, Sep 2, 2015, 1:46 PM Rich FitzJohn notifications@github.com wrote:

Don't forget to run the checks with --as-cran, which is disabled in the makefile.

— Reply to this email directly or view it on GitHub https://github.com/mwpennell/arbutus/issues/23#issuecomment-137239398.

mwpennell commented 8 years ago

finally passing all checks!

mwpennell commented 8 years ago

want to address a couple of the outstanding gh issues before submitting to cran