search

mwpennell / geiger-v2

A suite of methods and models for studying evolutionary radiations
22 stars 17 forks source link

fitContinuousMCMC Early Burst model fails #22

Closed SimonGreenhill closed 4 years ago

SimonGreenhill commented 8 years ago

Error message is

Error in .slater.getvcv(C, model, params) : object 'V' not found

Steps to reproduce:

library(geiger)
# all from example section of help('fitContinuousMCMC')
data(caniformia)
phy <- caniformia$phy
d <- caniformia$dat
node.priors <- caniformia$node.priors
root.prior <- caniformia$root.prior
fitContinuousMCMC(phy, d, model = "EB", Ngens = 1000, sampleFreq=100,
               printFreq = 100, node.priors = node.priors, root.prior = root.prior,
               outputName ="Trend_caniforms")

Version = geiger_2.0.6

SimonGreenhill commented 8 years ago

Ahh, I see that it's because the model "EB" has been replaced by "ACDC.exp" and "ACDC.lin" -- perhaps an error message on invalid model choices might be the way forward?

lukejharmon commented 8 years ago

Thanks for flagging that! We will fix as suggested.

lukejharmon commented 4 years ago

implemented (4 years later..!)