search

mwpenny / kijiji-scraper

A lightweight node.js module for retrieving and scraping ads from Kijiji
MIT License
96 stars 44 forks source link

Change CheerioElement to cheerio.Element #40

Closed sockcrates closed 4 years ago

sockcrates commented 4 years ago

This changes a typescript type to make tsc happy. It affects the package at build time only.

mwpenny commented 4 years ago

It looks like this just broke 2 days ago. The type definitions for cheerio were updated: https://github.com/DefinitelyTyped/DefinitelyTyped/commit/c9a000fa00e1b1d9334ee05e7625fe899ef9c911. Technically they should have considered this a breaking change, but oh well. Thanks for the quick PR!

Could you also update package.json so that the @types/cheerio devDependency is explicitly the latest version?

I.e.,

"devDependencies": {
    "@types/cheerio": "^0.22.22",
}
sockcrates commented 4 years ago

Thank you for the heads up! This was a pesky one. I updated the devDependencies as per the provided feedback.