search

mwpenny / portal64-still-alive

A demake of Portal for the Nintendo 64
MIT License
285 stars 39 forks source link

Use dropdown for closed captioning options #82

Open FoxbitDreamtail opened 1 month ago

FoxbitDreamtail commented 1 month ago

Version of the game

What is the enhancement?

change the subtitles tick boxes to a drop-down menu (Additional statement redacted)

Screenshots

image

Additional context

as-is it takes up a lot of unnecessary space in the menu and(Potentially) 2 menu options for subtitles could be confusing as to their meaning and use.

hackgrid commented 1 month ago

No, dropdown menu would be needed to be implemented from scratch and does not work well on N64 resolution.

Text language also affects menus without subtitles, it always needs to be visible. (Except only one language was built-in)

Foxbit @.***> schrieb am So., 11. Aug. 2024, 23:42:

Version of the game

  • Source Build: Aug.10.2024

What is the enhancement?

change the subtitles tick boxes to a drop-down menu and have the slider for text language only appear when subtitles are active Screenshots

image.png (view on web) https://github.com/user-attachments/assets/0a1d2eac-94c8-424b-9ad2-cc3315215579 Additional context

as-is it takes up a lot of unnecessary space in the menu and(Potentially) 2 menu options for subtitles could be confusing as to their meaning and use.

— Reply to this email directly, view it on GitHub https://github.com/mwpenny/portal64-still-alive/issues/82, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANGLFUSNQJJU2STEQNWSDZQ7LDPAVCNFSM6AAAAABMLCS3KWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TSNZXGM2TIMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

FoxbitDreamtail commented 1 month ago

I redacted the language thing for a reason. I don't see a problem with the drop-down menu with 3 options, Disabled, Subtitles(Dialog Only), and Closed Captions. also, isn't this setting normally in 'Audio' in the original game?

mwpenny commented 1 month ago

A drop-down is possible and I think it could potentially look okay (use same font as the menu itself), but it's non-negligible work for a pretty small benefit. And selecting the dropdown would result in effectively the same menu being displayed that we have today, but hidden behind one extra button press (inconvenient).

I don't mind keeping this open in case a dropdown is needed for some other menu element, or if someone wants to prototype it, but it will be quite low on the list and maybe not done at all.

You're right that it's normally in "audio". We have less space for menus at this low resolution, and it doesn't fit there. It's really a matter of perspective. After all, captions appear visually :)

FoxbitDreamtail commented 1 month ago

You're right that it's normally in "audio". We have less space for menus at this low resolution, and it doesn't fit there. It's really a matter of perspective. After all, captions appear visually :)

What about adding scrolling in the menus? it would make chapter select a little more pleasant and closer to the Console versions, and the cramped nature of the screen would be less of an issue!

mwpenny commented 4 weeks ago

Scrolling already exists for the control bindings menu, but that one's a bit different (just a list of selectable rows). The other menus don't really lend themselves well to it, particularly with the sliders. It's also easier for players if they can see everything at once where possible.

If more menu entries get added to the point of requiring scrolling outside of the controls menu, it can be tackled at that time. The menus would essentially need to be redone.

For the new game menu, console versions use a similar UI but also include arrows to indicate that scrolling is possible. Here is the Switch version: image. If this is what you mean, I agree it would be an improvement (and could also apply to the save/load menu). It isn't hard to add but is a low priority right now (PRs welcome).

FoxbitDreamtail commented 4 weeks ago

For the new game menu, console versions use a similar UI but also include arrows to indicate that scrolling is possible. Here is the Switch version: image. If this is what you mean, I agree it would be an improvement (and could also apply to the save/load menu). It isn't hard to add but is a low priority right now (PRs welcome).

Yeah, that's what I meant, all the console versions look the same, the XB360 version of Portal has an identical menu.