Fixed bav not working on other SDK types

mwpowellhtx / BumpAssemblyVersions

A flexible way of Bumping Assembly Versions with a rich set of instructions how to do so.

GNU General Public License v3.0

4 stars 0 forks source link

Fixed bav not working on other SDK types #7

Closed Germs2004 closed 3 years ago

Germs2004 commented 3 years ago

Removed a hardcoded filter on sdk type that was preventing the bav task from bumping the version on other sdk types, like Microsoft.NET.Sdk, Microsoft.NET.Sdk.WindowsDesktop, and Microsoft.NET.Sdk.Worker. Resolves issue #6

mwpowellhtx commented 3 years ago

I'll go ahead and accept this one, but I would like to see some unit tests vis-a-vis WinForms use cases versus "standard" Sdk use cases. It may require a bit of effort in the unit test project. As well as end-to-end usage cases. Which, reviewing some code, the abstractions are a bit thick, I will grant you that. The complexity, however, allows for scaffold like conventions adding new cases, or at least that was the motivation.