[LEGACY] [0022] Surrendered enemy counted as civilian

[mwpowellhtx]

Basic Information

Mission version: v0.97.0a Map used: Altis Mods used: Base set, including ACE, RHS Dedicated or local game: Local (for now)

Short Issue Description

• [ ] We need to be able to determine the original side of a unit

It is a non-trivial major issue. Surrendered enemy appear as civilians, because the core commands make it such.

[mwpowellhtx]

Initially I thought perhaps the bug was ACE medical related, i.e. when injured units succumbed to injuries, counts negatively because they are technically civilian side at that point, but no. The crux of the matter is setCaptive, whenever we see that happening, we need to establish the baseline side, and reference that instead. Extends into the kill manager, as well as for things such as capture action predicate conditions, in general.

• [x] Address core side attribution
• [x] Address capture action predicate conditions
• [x] Address kill manager side conditions

[mwpowellhtx]

I think the essential issues is addressed. There is a friendly fire issue which I am not sure is base game, difficulty, perhaps even ACE related. Does not seem to be anything directly mod related we are doing, with groups, etc.

[mwpowellhtx]

Review the capturing actions under these or similar conditions. Side should be converted to that of the securing unit, and not necessarily baselined to that of the surrendering unit. We think that this makes the absolute most amount of sense, regardless of the surrender scenario.

[mwpowellhtx]

Gremlin tasks:

• [x] When units surrender this invokes setCaptive, which forces civilian side convertion
• [x] Therefore it is necessary to introduce a baseline sidedness variable on the units involved prior to doing these things
• [x] Best possible place we think of doing this is during the prisoner_ai server side callback
• [x] In addition any references to side _x, side group _x, and so on, need to filter through KPLIB_fnc_side function

[mwpowellhtx]

Gremlin note #1:

As much bug as it is non-trivial, best case minor, worst case major, enhancement. Mostly have it sorted now, but it did expose the necessity for some increased biases while evaluating for sector ownership, unit surrender, and so forth.

[mwpowellhtx]

Gremlin note #2:

In addition to which, was observing that when mistakes are made, captive executions and so forth, this kicks the offender out into no man's land, group wise, it seems like. Any actions the offender was previously able to do, such as capture currently surrendered units, are nilified it seems like. Working with newly surrendered units seems ot be fine however.

Not sure why this is, if it is mod related, thinking probably base game, difficulty, perhaps ACE settings. However, the core issue being addressed, seeing captured, interrogated, units as civilian, avoiding consequent penalties therein, that much has been addressed.

Not sure it is worth pursuing this other idiosyncacy, outside of making this report, and leaving space for potential lessons learned moving forward into earnest redeux efforts.

[mwpowellhtx]

Gremlin note #3:

Closing this one, but if something jumps out as a plausible root cause, let alone what we may do about it further than we have, will reconsider additional steps.

[mwpowellhtx]

Should probably verify this did the trick before getting too far ahead of things and having to roll out further updates.

[mwpowellhtx]

Seems like it is working.