search

mwrock / RequestReduce

Instantly makes your .net website faster by reducing the number and size of requests with almost no effort.
www.requestreduce.org
Apache License 2.0
228 stars 48 forks source link

Problem using combined Google Web Fonts #139

Closed fjeldstad closed 12 years ago

fjeldstad commented 12 years ago

Hi,

I've noticed that when you have a reference to a Google Web Fonts stylesheet that includes multiple fonts, they don't get loaded properly when RequestReduce is enabled. For example, this works just fine for loading the font "Alfa Slab One":

<link href="http://fonts.googleapis.com/css?family=Alfa+Slab+One" rel="stylesheet" type="text/css">

But this attempt to load both "Alfa Slab One" and "Bree Serif" at once fails:

<link href="http://fonts.googleapis.com/css?family=Alfa+Slab+One|Bree+Serif" rel="stylesheet" type="text/css">

Since the purpose of using the combined CSS is to reduce the number of requests (which is exactly what RequestReduce will do anyways) one could argue that simply using one separate <link>element per font is a good workaround. Still, I thought I'd let you know.

mwrock commented 12 years ago

Can you confirm you have the latest version (v1.7.94) or ar least a version of 1.7.61 or greater? This was actually addressed in issue #128 and fixed in v1.7.61. RequestReduce had problems with a pipe in the url. If you grab 1.7.94 (the latest nuget package) then you should no longer see this problem. Thanks!

fjeldstad commented 12 years ago

You're right - I had actually updated to 1.7.94 but I've must have been using the old binaries somehow. Have verified that it works after clearing out the old package from disk and rebuilding completely. Thanks!