mwrock / RequestReduce

Instantly makes your .net website faster by reducing the number and size of requests with almost no effort.
www.requestreduce.org
Apache License 2.0
228 stars 48 forks source link

Dependency on SassAndCoffee libraries #140

Closed cmjacques closed 12 years ago

cmjacques commented 12 years ago

Hi Matt, hope you're well.

I've just skipped ahead from RR v1.6.19 to the latest v1.7.94 and noticed that if I want to use the built in LESS functionality in RequestReduce.SassLessCoffee I now have to also reference SassAndCoffee.Ruby and SassAndCoffee.Javascript.

With v1.6.19 all I had to do was add a reference to RequestReduce, RequestReduce.SassLessCoffee and dotless.Core and the LESS stuff just worked.

All I am interested in at this stage is LESS and I know it's not a big deal, but I don't like having unnecessary code/assemblies in my projects.

Would it be possible to break the LESS, SASS and CoffeeScript stuff into separate packages? So if I choose to just use LESS then I would referrence RequestReduce.Less and its' required dependencies only?

Cheers, Chris

mwrock commented 12 years ago

Hi Chris. Thanks for pointing this out. I never really envisioned this scenario but it makes sense and I can see why if you are just using LESS, you don't really want to bring along all the other binaries.

Separating the packages may be the best option, but its easy to move things around just a bit so that the SassLessCoffee dll can do Less compilation without the SassAndCoffee stuff as well as their dependencies. I just made that change and will be pushing out a new package shortly.

mwrock commented 12 years ago

This is pushed and available in 1.7.100

cmjacques commented 12 years ago

Hi Matt, I've just grabbed 1.7.100 and it's working a treat. Thanks!