search

mwrock / RequestReduce

Instantly makes your .net website faster by reducing the number and size of requests with almost no effort.
www.requestreduce.org
Apache License 2.0
228 stars 48 forks source link

$(SolutionDir) is wrong when using NuGet Package Restore #159

Closed tsolbjor closed 12 years ago

tsolbjor commented 12 years ago

When using the Package Restore function in NuGet, the $(SolutionDir) property is set with a relative path pointing to the directory where the actual .sln is.

RequestReduce is using the $(SolutionDir) property in the buildevents to navigate to the package folder, but now $(SolutionDir) points to a directory relative to the target directory of the project (ie /bin) and therefore it won't find the files necessary.

mwrock commented 12 years ago

Interesting. I just switched over to using the Package Restore functionality myself. Let me give this a try later tonight or this weekend and I'll make sure to get this fixed. Thanks!

mwrock commented 12 years ago

Sorry it has been a while but while catching up on issues this weekend I tried this out on a empty asp.net project with projectrestore enabled. I cleaned the build and blew away the packages folder and then rebuilt. Optipng was where it should be and the post build looked fine.

There has been a Nuget update to 1.7 since opening this issue which may have addressed this. Let me know if you still see this and maybe some repro steps I'm missing.

Thanks!