search

mwrock / RequestReduce

Instantly makes your .net website faster by reducing the number and size of requests with almost no effort.
www.requestreduce.org
Apache License 2.0
228 stars 49 forks source link

Javascript processing of Elfinder.org package #197

Open ngjermundshaug opened 12 years ago

ngjermundshaug commented 12 years ago

Minimizing Elfinder (www.elfinder.org) does not work properly. Produces javascript errors.

Had to add this filter to make it work: RequestReduce.Api.Registry.AddFilter(new RequestReduce.Api.JavascriptFilter(x => x.FilteredUrl.ToLower().Contains("commands/t"))); RequestReduce.Api.Registry.AddFilter(new RequestReduce.Api.JavascriptFilter(x => x.FilteredUrl.ToLower().Contains("commands/u"))); RequestReduce.Api.Registry.AddFilter(new RequestReduce.Api.JavascriptFilter(x => x.FilteredUrl.ToLower().Contains("commands/v")));

ElFinder can be download here (maximized): https://github.com/Studio-42/elFinder/zipball/2.x

mwrock commented 12 years ago

Hi and thanks or reporting this. My guess is that you are running into a known issue where the javascript is attempting to load other scrits from a path relative to itself. This often breaks under RequestReduce because the scripts are transformed and moved to a different directory which is ~/RequestReduceContent by default. I'd bet that the Commands scripts that you are ignoring may be loading other scripts and expecting those scripts toi be in the same directory.

Let me know if this does not sound right.

ngjermundshaug commented 12 years ago

The Command scripts are not loading any other javascripts as far as I know.

I suggest that you download the ElFinder package, run it through RequestReduce to reproduce the error.

This issue should not be closed.

mwrock commented 12 years ago

That's fair. Reopening.