add #unless helper functionality

mwunsch / handlebars.scala

A Scala implementation of the Handlebars templating language (a superset of Mustache).

Apache License 2.0

112 stars 40 forks source link

add #unless helper functionality #46

Closed theshortcut closed 9 years ago

timcharper commented 9 years ago

unless is a built-in helper for handlebars, and should probably be supported.

timcharper commented 9 years ago

Hi Mark / Chris,

This is a bit of a big patch. It brings in the play-json integration as an addon library, which can be published with handlebars (and using the same version).

I added an sbt task, updateVersion, which updates the README.md files to use the current version, as specified in sbt. There is also an aggregator project, all. Steps to release a new version might look like this:

edit build.sbt, update version
sbt all/updateVersion
sbt all/publishSigned

I've updated the README.md for handlebars-scala-play-json and synchronized the example code to work with the latest package schemes.

I hope you'll consider including this patch, and deploying the handlebars-scala-play-json jar along with handlebars releases. I think it will benefit the users of the library, and make integration with other JSON libraries within reach.

timcharper commented 9 years ago

Okay, I've pushed a new patch.

I fixed the typo, I made a note about play 2.4.x, I updated Scala to 2.10.5, and I ripped out the non-standard helpers. I also removed the _ from the package name, and made it parallel with the dynamic binding package (should have done that to begin with, too).

So, for dynamic binding, import:

import com.gilt.handlebars.scala.binding.dynamic._

And, for playjson binding, import

import com.gilt.handlebars.scala.binding.playjson._

Thanks for taking some time to review the patch, Chris, I appreciate it!

chrhicks commented 9 years ago

Love it. One more instance of play_json to convert.

Also, since you've changed the deploy process, would you mind making a DEPLOY.md where the steps are outlined (like you did earlier in comments here).

Other than that this looks good to me.

timcharper commented 9 years ago

Doh!!!! The tests!!! The tests!

DEPLOY.md pushed

On Aug 10, 2015, at 20:57, Chris Hicks notifications@github.com wrote:

Love it. One more instance of play_json to convert.

Also, since you've changed the deploy process, would you mind making a DEPLOY.md where the steps are outlined (like you did earlier in comments here).

Other than that this looks good to me.

— Reply to this email directly or view it on GitHub https://github.com/mwunsch/handlebars.scala/pull/46#issuecomment-129686701.