mwunsch / handlebars.scala

A Scala implementation of the Handlebars templating language (a superset of Mustache).
Apache License 2.0
112 stars 40 forks source link

Remove slf4j-simple dependency #48

Closed cimbul closed 8 years ago

cimbul commented 9 years ago

The handlebars-scala project depends on both slf4j-api and slf4j-simple. The latter is an SLF4J binding. This means that any project depending on handlebars-scala transitively depends on slf4j-simple, which conflicts with any other SLF4J binding they might want to use (e.g., Logback, Log4J).

The recommended approach for libraries is to depend on slf4j-api only. Could you remove the slf4j-simple dependency? If you need it for tests, you can always mark it with the test scope.

timcharper commented 8 years ago

Had to rebase because merge conflict. Merged. Thank you and sorry this was hanging so long!!! Sheesh!