search

mwunsch / handlebars.scala

A Scala implementation of the Handlebars templating language (a superset of Mustache).
Apache License 2.0
112 stars 40 forks source link

add implicit codec to handle java.nio.charset.MalformedInputException #60

Closed dgouyette closed 8 years ago

dgouyette commented 8 years ago 
"scala.io.BufferedSource.mkString(BufferedSource.scala:96)",
    "com.gilt.handlebars.scala.partial.PartialHelper$.findAllPartials(PartialHelper.scala:51)",
    "com.gilt.handlebars.scala.partial.PartialHelper$.getTemplates(PartialHelper.scala:67)",
    "com.gilt.handlebars.scala.DefaultHandlebarsBuilder$.apply(HandlebarsBuilder.scala:40)",
    "com.gilt.handlebars.scala.Handlebars$.createBuilder(Handlebars.scala:48)",

see http://stackoverflow.com/questions/13625024/how-to-read-a-text-file-with-mixed-encodings-in-scala-or-java

timcharper commented 8 years ago

Hmm, it seems like maybe this should be parameterized.

dgouyette commented 8 years ago

Ok I'll update my pull request 😏

dgouyette commented 8 years ago

Pull request updated

timcharper commented 8 years ago

Perfect! A default implicit Codec is provided by Scala so source compatibility should be retained.