search

mwunsch / prism

A Ruby microformat parser and HTML toolkit powered by Nokogiri
MIT License
63 stars 9 forks source link

Prism is broken with the latest nokogiri release #5

Open taazza opened 14 years ago

taazza commented 14 years ago

/home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/microformat/hcard.rb:60:in []': can't convert String into Integer (TypeError) from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/microformat/hcard.rb:60 from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism.rb:102:incall' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism.rb:102:in extract_from' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism.rb:109:inparse' from /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in collect' from /home/test_prism/vendor/gems/ruby/1.8/gems/nokogiri-1.4.2/lib/nokogiri/xml/node.rb:402:incall' from /home/test_prism/vendor/gems/ruby/1.8/gems/nokogiri-1.4.2/lib/nokogiri/xml/node.rb:402:in each' from /home/test_prism/vendor/gems/ruby/1.8/gems/nokogiri-1.4.2/lib/nokogiri/xml/node.rb:401:ineach' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism.rb:109:in collect' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism.rb:109:inparse' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:144:in get_properties' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:140:ineach_pair' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:140:in get_properties' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:175:into_h' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:195:in empty?' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:148:inget_properties' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:147:in reject' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:147:inget_properties' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:175:in to_h' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:165:in[]' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/posh/base.rb:92:in fn' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/lib/prism/microformat/hcard.rb:99:into_vcard' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/bin/prism:95 from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/bin/prism:80:in parse_microformats' from /home/test_prism/vendor/gems/ruby/1.8/gems/prism-0.1.0/bin/prism:95 from bin/prism:3:inload' from bin/prism:3

When we instruct Gem bundle to use 1.4.1 everything works fine ;) Might be better off declaring which version of the dependency you need.

atd commented 14 years ago

Same problem here, please fix it :-)

otobrglez commented 13 years ago

Same problem here. With Ruby 1.8.7-p330 and 1.9.2-p136.

ghost commented 13 years ago

Aha. This explains a lot. Spent the last hour or so trying to figure out where I was going wrong. This explains it :-)

The fact that this is still broken after a year is somewhat disturbing. Has anyone made any headway with this?

ghost commented 13 years ago

Fixed in my fork. Sent a pull request.

josephholsten commented 11 years ago

Could you please merge and release?

mwunsch commented 11 years ago

Merged, but having trouble releasing b/c this gem is real old.

I do have plans for it though. @josephholsten: do you need this gem to be released or can you point to the git repo?

josephholsten commented 11 years ago

I'd like a release to complement my webfinger toolkit discodactyl.

Do you have the time to maintain this? I can certainly help if that's useful.

mwunsch commented 11 years ago

Was hoping to rewrite it actually :neutral_face:

josephholsten commented 11 years ago

Awesome. If there's anything I can do to keep prism 0.1 on life support while you're rewriting, let me know. mofo is beyond help at this point, so prism really is the best thing around for microformats.

mwunsch commented 11 years ago

Well, I merged @Nimlhug's pull request in, but am unable to run the tests and am seeing lots of bundler errors. If you feel like taking over the version 0.1.0 branch of prism and figure out how to lock down the dependencies to have it run easily (in Ruby 1.8.7), I can begin working on a 0.2.0 branch.