search

mwunsch / weary

A framework and DSL for building RESTful web service clients
MIT License
482 stars 23 forks source link

Addressable 2.3.2 #24

Closed mariochavez closed 11 years ago

mariochavez commented 11 years ago

Hi;

I have a project were I'm using Weary and Jasmine gems, Jasmine needs addressable 2.3.2 while Weary depends on addressable 2.2.7.

I tried just to bump addressable version but there is a change there to not support nested hashes - as Rails does -. So far that change in addressable breaks a test in Weary at:

https://github.com/mwunsch/weary/blob/master/spec/weary/request_spec.rb#L143

I sent a path to addressable to restore support to nested hashes but it turn out that support was not dropped due to a regression, it was removed https://github.com/sporkmonger/addressable/issues/77 because parameters like nested hashes are not supported by RFC 3986 specs.

Now to my question, can we just drop the test that fail with latest addressable version and have Weary use it? I know that this will fix my issue, but potentially can break another use cases, but this decisions needs to be donde sooner or later.

mwunsch commented 11 years ago

I'll update this test to transform the request params to json, since that is the expected input in this api. It's important to me that the specs of Weary actually demonstrate requests to real-world API's.