search

mwunsch / weary

A framework and DSL for building RESTful web service clients
MIT License
482 stars 23 forks source link

Add support for Ruby 2.0.0 #33

Closed gabceb closed 11 years ago

gabceb commented 11 years ago

I've tried running rspec with Ruby 2.0.0 and it seems like Content-type is not being set correctly for some of the requests.

I've tried fixing this issue but is taking me some time to understand the code so maybe one of the repo collaborators can give me a hand here.

rspec ./spec/support/shared_examples_for_a_rack_app.rb:62 # Weary::Adapter::Excon class methods behaves like an Adapter #call behaves like a Rack application the headers contains a 'Content-Type' header
rspec ./spec/support/shared_examples_for_a_rack_app.rb:62 # Weary::Adapter::Excon behaves like an Adapter #call behaves like a Rack application the headers contains a 'Content-Type' header
rspec ./spec/support/shared_examples_for_a_rack_app.rb:62 # Weary::Adapter::NetHttp class methods behaves like an Adapter #call behaves like a Rack application the headers contains a 'Content-Type' header
rspec ./spec/support/shared_examples_for_a_rack_app.rb:62 # Weary::Adapter::NetHttp behaves like an Adapter #call behaves like a Rack application the headers contains a 'Content-Type' header
rspec ./spec/support/shared_examples_for_a_rack_app.rb:62 # Weary::Adapter::Typhoeus class methods behaves like an Adapter #call behaves like a Rack application the headers contains a 'Content-Type' header
rspec ./spec/support/shared_examples_for_a_rack_app.rb:62 # Weary::Adapter::Typhoeus behaves like an Adapter #call behaves like a Rack application the headers contains a 'Content-Type' header
rspec ./spec/support/shared_examples_for_a_rack_app.rb:62 # Weary::Middleware::BasicAuth#call behaves like a Rack application the headers contains a 'Content-Type' header
rspec ./spec/support/shared_examples_for_a_rack_app.rb:62 # Weary::Middleware::ContentType#call behaves like a Rack application the headers contains a 'Content-Type' header
rspec ./spec/support/shared_examples_for_a_rack_app.rb:62 # Weary::Middleware::OAuth#call behaves like a Rack application the headers contains a 'Content-Type' header
gabceb commented 11 years ago

Maybe @mwunsch can shed some light on this?

mwunsch commented 11 years ago

Working on it now; as of:

January 21st, 2013: Thirty third public release 1.5.0

Rack::Response no longer forces Content-Types

Commit 19a6e2a0ad7ec3f0ad9071022f87c5a76c11cf25 ensures that 2.0.0 is tested in CI and commit 568db3ffd911a2a713cc0c4406660c16f5510ac5 loosens/updates dependencies.

mwunsch commented 11 years ago

Build passes: https://travis-ci.org/mwunsch/weary/jobs/6360975

Feels right to remove the failing test in this case since the actual software spec changed. Need to do another scan of these specs to make sure they are up to date.

gabceb commented 11 years ago

Thank you, sir. :shipit: