search

mwvgroup / Pitt-Google-Broker

A Google Cloud-based alert broker for LSST and ZTF
https://pitt-broker.readthedocs.io/en/latest/index.html
4 stars 0 forks source link

Port the Salt2 Beam code into a Cloud ~Function~ Run #98

Open troyraen opened 2 years ago

troyraen commented 2 years ago

Salt2 fits were performed in Dataflow prior to #94. Port the code into a new Cloud Function so that we retain the option of running them.

I think you should keep SALT2 as a thing you can run. In general, we will want to be able to run various classifiers/fitters, SALT2 is one of them, SuperNNova, Upsilon, etc. These are all just functions that take as input the alert data and produce a classification, score, fit parameters as outputs. They should structurally fit in in the same way in the pipeline.

If what you're saying is that you should remove the Dataflow job that runs SALT2, then of course, yes. But we will want to be able to run SALT2 on the input data.

Originally posted by @wmwv in https://github.com/mwvgroup/Pitt-Google-Broker/issues/94#issuecomment-916050731

troyraen commented 2 years ago

We're moving towards Cloud Run, so Salt2 should be ported there.