Fix Codacy issues - Githubissues

mwvgroup / Pitt-Google-Broker

A Google Cloud-based alert broker for LSST and ZTF

https://pitt-broker.readthedocs.io/en/latest/index.html

4 stars 0 forks source link

Fix Codacy issues #99

Open troyraen opened 2 years ago

troyraen commented 2 years ago

@cmazzdaher @djperrefort The feedback from Codacy is helpful, but there are a lot of little things to fix. I'd like to get the currently open PRs merged together, and then do a separate PR dedicated to fixing all this stuff. So I'd like to punt on all these Codacy issues for now. None of them look urgent to me.

Originally posted by @troyraen in https://github.com/mwvgroup/Pitt-Google-Broker/issues/71#issuecomment-922170218

djperrefort commented 2 years ago

@troyraen I think this is the right way to use a QA tool. It’s better to take the approach of gradual improvement than to fix everything at once (with the occasional targeted effort here and there)

troyraen commented 2 years ago

In SQL statements, the table name cannot be parameterized. A recommendation is to use the scripting statement EXECUTE IMMEDIATE.
consider replacing pickle files to reduce security risk