mwvgroup / csp-cmfgen

A comparison spectral SNe models against CSP data
https://mwvgroup.github.io/nir-comparison/
0 stars 0 forks source link

Add color chi-squared values and delta color 15 #18

Closed djperrefort closed 5 years ago

djperrefort commented 5 years ago

Major Changes

Minor Changes

Notes / requests for reviewer

The files included in the scope of this pull request include the analysis/lc_colors module in addition to the lc_gaussian_regression.ipynb and color_evolution.ipynb notebooks. The module includes the core analysis logic, while the notebooks are mostly plotting code. Note that analysis/lc_colors/_lc_regression.py is a port of logic from avocado and can be ignored in the review.

I am not confident in my shifting of the model time scales to the t0 point of the observed light curves. The code for tabulating the chisquared values (in analysis/lc_colors/_chi_squared.py) definitely got away from me and any feedback concerning simplification is especially appreciated.

djperrefort commented 5 years ago

@wmwv I've addressed your requested changes. Can you take another look?

djperrefort commented 5 years ago

@wmwv I have the football

djperrefort commented 5 years ago

This PR was merged via git but not recognized by GitHub. I'm closing it.