search

mwvgroup / csp-cmfgen

A comparison spectral SNe models against CSP data
https://mwvgroup.github.io/nir-comparison/
0 stars 0 forks source link

Time unit conversion should always happen at earliest possible level. #23

Closed djperrefort closed 4 years ago

djperrefort commented 5 years ago

We are converting from various time formats to JD at multiple points of the analysis pipeline. For consistency and to avoid mistakes, this should be done in utils.py and whenever we call upon sndata. This is both more consistent and will lead to fewer bugs.

djperrefort commented 4 years ago

This issue is addressed by the above PR and by SNData standardizing to use JD.