This pull request addresses issue #23. It ensures that all time values are formatted in Julian Date format at the lowest possible level.
Major changes
Increases the required sndata version to 0.6.0. This ensures that all data tables formatted for use with sncosmo use JD format. All non-formatted tables also have a Julian Date times (with the possibility of a different time format provided in a separate column)
The utils.get_csp_t0 function now returns times in JD
The utils.parse_spectra_table function returns time values in JD. This change is negligible when working with CSP DR1 data since those time values were already in JD.
It is worth noting that a quick glance at the results indicates this change resulted in different, more reasonable values being calculated by the equivalent_width module. However, the handling of t0 by that module was already known to be wrong so looking into it further is not worth much and is outside the scope of this PR. The results from the lc_colors module are unchanged.
This pull request addresses issue #23. It ensures that all time values are formatted in Julian Date format at the lowest possible level.
Major changes
sndataversion to0.6.0. This ensures that all data tables formatted for use withsncosmouse JD format. All non-formatted tables also have a Julian Date times (with the possibility of a different time format provided in a separate column)utils.get_csp_t0function now returns times in JDutils.parse_spectra_tablefunction returns time values in JD. This change is negligible when working with CSP DR1 data since those time values were already in JD.It is worth noting that a quick glance at the results indicates this change resulted in different, more reasonable values being calculated by the
equivalent_widthmodule. However, the handling oft0by that module was already known to be wrong so looking into it further is not worth much and is outside the scope of this PR. The results from thelc_colorsmodule are unchanged.