mwvgroup / pittgoogle-user-demos

GNU General Public License v3.0
2 stars 0 forks source link

Add MicroLIA classifier #13

Open wmwv opened 1 year ago

wmwv commented 1 year ago

Add microLIA micro-lensing classifier

https://github.com/Professor-G/MicroLIA

  1. [x] Generalize code to support multiple classifiers
  2. [ ] Add MicroLIA as one of those classifiers
  3. [ ] Create training set file to store for MicroLIA
  4. [ ] Test
wmwv commented 1 year ago

@troyraen Should "-classifier-" in this cloudbuild line be instead "-supernnova-" or "-microlia-"?

https://github.com/mwvgroup/pittgoogle-user/blob/main/classifier/cloudbuild.yaml#L16

troyraen commented 1 year ago

That variable, _MODULE_NAME, needs to be the same as the module_name variable in the setup.sh script. The setup.sh script sends the variable in as an argument. So the line you pointed to in cloudbuild.yaml is a default value that doesn't actually get used.

So my vote is probably to leave it as "-classifier-", unless there's something even more general we want to replace it with.

troyraen commented 1 year ago

(I think that a default value has to be defined. But if I'm remember that wrong and it's not actually required, it might be better to just take that line out.)

wmwv commented 1 year ago

Thank you. That is most helpful.