search

mx-moth / flask-saml2

Flask library for building SAML Service Providers and Identity Providers
MIT License
70 stars 61 forks source link

Fix a bug with non-signed requests in the IdPHandler class. #11

Closed Jeff-Meadows closed 5 years ago

Jeff-Meadows commented 5 years ago

If the service provider isn't signing requests, then the _make_idp_request_url method turns the query string into a bytestring before including it in a format string below.

This causes the resulting URL to include the literal characters

b'

preceeding the desired contents of the query string.

This commit removes the call to encode('utf-8') so the url is generated correctly.

mx-moth commented 5 years ago

Thanks for this fix! I've pushed version flask-saml 0.2.1 to pypi with this fix included.

Jeff-Meadows commented 5 years ago

Thanks!