mx3L / subssupport

GNU General Public License v2.0
7 stars 27 forks source link

DVB Player subitles speedup or slowdown #10

Open YoKo666 opened 8 years ago

YoKo666 commented 8 years ago

Can you please add this support to DVBPlayer Subsupport? So we can fine-tune subtitles.. LEFT-RIGHT arrows move "one title" ahead or back, but how about adding option to slow/speed up for 0.5 sec (key 4 or 6) and +-1.0 sec with keys 1 and 3 If the option is there it doesn't work, at least for DVBPlayer. Also, a small cosmetic change.. Option so we can change distance between 2 lines of titles (when there are 2 or more lines on screen at the time). By doing this we can be able to split background so it doesn't have to be at one piece. Adding an option of background to be 0px out of fonts will be also useful. Thanx in advance..Best subtitler there is :+1:

mx3L commented 8 years ago

Thanks for very good suggestions.

Currently working on fine-tuning: I've implemented this by doing seeking to precise time. Currently I'm thinking about binding it to up/down button:

UP: seek +200ms DOWN: seek -200ms UP/DOWN for restartSubtitle moved to OK OK for showing status, moved to INFO

Have to think about how to show this operation in GUI, will send here some test version once done.

YoKo666 commented 8 years ago

Hello there and thank you for your reply. Mind that some boxes (ie. VU+) don't have INFO button on remote, so it would be impossible to see status.Maybe if you add it to [TV] button? Otherwise, the scheme is ok, option with OK button. As for lines, when there are more than 2 lines of text DVB player doesn't show it correctly on screen. It shows 3 lines in 2, what makes a mess to read because you see bottom of first line, you see the whole 2nd line and you see only top of the 3rd line of text in 2 rows. Impossible to read and really not an eye candy :) Looks like DVB player isn't capable of reproducing more than 2 lines of text on screen. Otherwise, as i can say (not a noob) best subtitler can be even better with this :)

YoKo666 commented 8 years ago

Any progress please?

YoKo666 commented 8 years ago

Can we expect new version please? Thank you!

mx3L commented 8 years ago

Hi didn't get to finish it yet, hopefully this week..

YoKo666 commented 8 years ago

That's wonderful news! Looking forward to it. Best subtitler so far, with this new option will be even better.

mx3L commented 8 years ago

Hi,

  1. EPG button on VU should be the same as INFO button elsewhere.
  2. I don't see problem with 3 lines: 3lines

Can you test this sample srt file, how it shows 3 lines for you? test_tags.zip

YoKo666 commented 8 years ago

Yes, seems to be OK, guess something was wrong with the subtitle encoding then with my downloaded sub. Can you notice the bug with italic/bold/regular at same line on your picture? It shows all italic, even the first line is BOLD, second ITALIC and third REGULAR? Seems to me that Italic has highest priority in subitltes and then it changes the whole lines to italic. Can this be fixed also? Looking forward to new version :)

YoKo666 commented 8 years ago

Any news please?

mx3L commented 8 years ago

Hello, sorry I didn't finish GUI part, thought these mini seeks are now possible, please try it if it works as it should. UP/DOWN are now for fine adjustments. https://dl.dropboxusercontent.com/u/38760017/enigma2-plugin-extensions-subssupport_1.5.4-20160215_all.ipk

YoKo666 commented 8 years ago

It doesn't work, now and UP and DOWN have same function, reloads sub at line start time :(

mx3L commented 8 years ago

I double checked contents of subssupport which I posted you and it's all right, so UP/DOWN is changing subtitles time by +-200ms. So It looks like you have still old version there.

Look at the picture above which I posted. In new version "Subtitles Time" also shows miliseconds. If you see miliseconds then it's installed properly, now you're seeing probably only seconds.

YoKo666 commented 8 years ago

Hmm..you're right, my box says _ not downgrading previous version (which is the one i've downloaded from here before). So, the timestamp is not right then on your new version looks like. Anyway i will try to delete completely older version and install new one then i will report.

mx3L commented 8 years ago

I had to change versioning, because of creating now also debian package. That's why is telling you that what are you trying to install is older version.

Just use opkg --force-downgrade install enigma2-plugin-extensions-subssupport...

YoKo666 commented 8 years ago

Yes, i can confirm it is working flawless!! Thanx, it's the real thing that was missing now it's ok! SubSupport getting better and better :+1: Anyway the only flaw is you need to uninstall older version first coz of wrong timestamp or something. On my box it wouldn't want to upgrade over older version enigma2-plugin-extensions-subssupport_1.5.4_20151105_all.ipk so,you might want to look into it also :) Thank you once more for this great sub-app :)

mx3L commented 8 years ago

Glad to hear that :), I'm still not sure how should it appear in user interface when someone presses UP/DOWN, is it good to just show status bar, where you can see that by pressing these buttons is actually subtitles time changing?

I was thinking, that maybe instead of showing status bar, there should shown label somewhere with operation name, i.e when presses UP, on screen there will be shown "+200ms" and then it will fade/change color if you don't press again, I think it would be cleaner. Or maybe you have better suggestion?

YoKo666 commented 8 years ago

I think maybe an option in settings with 3 options:

YoKo666 commented 8 years ago

Found few bugs in your new version 1.5.4-20160215 . First, the buttons < and > (not on a wheel with UP and DOWN, but those on numpad) doesn't work anymore. Those were for skipping few minutes of titles (forward/backward). Now the buttons reset subs to 0:00. No option to enter direct time of subtitle jump.. Also, if you put option to sync event, if the time is higher than 30 or more minutes for position the titles, it crashes E2. Can you please look into it? Otherwise HELP button crashes E2 on Vu+ is another bug.

YoKo666 commented 8 years ago

Found another bug, and this one's big! With the new version 1.5.4-20160215, when i speed the sub with UP or DOWN, after some time (usually 5-7 minutes) the subs goes out of sync (it just doesn't match anymore, subs goes to +-1sec or even more, similar like i've changed automatically FPS from 23.976 to ie 24), so after every 5-7 minutes the subs has to be speeded or slowed again. I've tested SAME sub with old version (uninstalled newer) and the subs are ok (as i sync them at the beginning they stayed in sync for the whole movie), no need to readjust.So i think this version broke the timing of the subs!! Another bug is when i press UP or DOWN when no lines on screen it jumps to the next line and not +-200ms, it then f**ks up the whole timing. I've reverted to the old version, and it's more stable with all the bugs polished (except Italic takeover priority over regular or bold font)..

mx3L commented 8 years ago

Thanks for letting me know, it's rewritten almost from scratch with not much testing done, so it's certainly possible that there are bugs in there. I will try to fix it.

YoKo666 commented 8 years ago

Nice to hear it.. :) Thanx for your support!

YoKo666 commented 8 years ago

Any news or ETA? :)

mx3L commented 8 years ago

Hello, will try to provide some in near future, stay tuned :)

YoKo666 commented 8 years ago

Looking forward for a new and a fixed version :)

mx3L commented 8 years ago

Also, if you put option to sync event, if the time is higher than 30 or more minutes for position the titles, it crashes E2.

Can you post crashlog?

YoKo666 commented 8 years ago

I think this is the right one..i have many and i've deleted this bugged version.. http://notepad.cc/hinaovu7

mx3L commented 8 years ago

Thanks

YoKo666 commented 8 years ago

No news?

mx3L commented 8 years ago

Hello, As you know this request is here many months now, with not so great results, due to my limited time invested in it and advanced challenge to get timing right with tiresome testing, when rewards are not so great.

I just want you to know that I know about this issue (it's still bothering me :)). I will not make promises like this again

Hello, will try to provide some in near future, stay tuned :)

since it looks like I'm not doing good estimate.

YoKo666 commented 7 years ago

:) Sorry if i am too annoying.. But is there a chance of new version? :)