mx3m / hikari-for-jekyll

An open-source theme for Jekyll
http://mx3m.github.io/hikari-for-jekyll
MIT License
235 stars 86 forks source link

SCSS + Variables + Relative Units #22

Closed mx3m closed 10 years ago

mx3m commented 10 years ago

Alright. So this is the big one.

The overall architecture of this theme has changed dramatically. I don't have a lot of time so had to do this in a few hours. Far from being perfect but I tried to keep it as simple as possible (for me, and everyone else).

There is now a side nav (instead of the one on top). It looks like this:

screen shot 2014-07-02 at 19 14 58

SCSS obviously allowed me to make variables. There is only 1 $main-color variable to change to make this theme unique.

screen shot 2014-07-02 at 19 17 30

screen shot 2014-07-02 at 19 17 44

Not ready for a merge right now but making this PR so the few persons interested in Hikari can try it out and help making this better.

My plan is to move the bio description & social links (twitter, instagram etc) to _config.yml to make it even easier for people with little experience to get started with Jekyll.

Cheers, Mathieu

ssorallen commented 10 years ago

I follow several design guidelines for CSS that are used by widely-installed frameworks like Bootstrap and Foundation. You can argue they are personal preference, but used together they lead to a more sustainable and customizable use of CSS and have helped Bootstrap and Foundation become as successful as they are.

mx3m commented 10 years ago

Agree with everything you said.

When I made this theme I had very little knowledge of CSS best practices.

I barely touched the HTML files as you can see in the PR which can explain why I haven't converted all unecessary IDs to classes.

I'll have a better look at it tomorrow and clean it up. Thank you for insisting on these points that I believe to be essential too.

ssorallen commented 10 years ago

:+1: The move to Scss is great. Nice work, @m3xm.

mx3m commented 10 years ago

@ssorallen fixed most things I think ;p

Posts typography is cleaner too. I might change the theme default color to celebrate 2.0 :p Any suggestion?