Closed ghost closed 10 years ago
Are there appropriate color variables for some of the pagination styles in https://github.com/m3xm/hikari-for-Jekyll/blob/master/_scss/base/_variables.scss?
The "main" color of the pagination buttons is inherited directly from:
a {
color: $link-color;
&:hover {
color: $text-color;
}
}
(specified in: https://github.com/m3xm/hikari-for-Jekyll/blob/master/_scss/base/_global.scss)
The $link-color
is actually pointer to $main-color
so we can say that this color will always be equal to the currently chosen main color.
Other colors reserved by those buttons are merely different shades of gray (#f5f5f5, #eee and #ccc) so I guess their values don't need to be moved to separate variables.
Yeah, you are right, nice catches! I felt kind of strange using variables for every single color, but now when I think about it, you are absolutely right. This way, the theme is much more customizable!
Let's say it makes the whole customization easier somewhat.
@ssorallen if you're fine with the PR, you can merge :p
:shipit: Looks good to me.
Howdy!
I was checking out the brand new version of Hikari a while ago and I seriously gotta say that I love all of the changes! However I found out that the new SCSS files are missing specification for style of main homepage paginator which causes the buttons handling page redirection to look pretty ugly. So here I am with hotfix... :)