mx3m / hikari-for-jekyll

An open-source theme for Jekyll
http://mx3m.github.io/hikari-for-jekyll
MIT License
235 stars 86 forks source link

Configurable GA, Atom RSS feed, and fewer CSS bytes #3

Closed ssorallen closed 10 years ago

ssorallen commented 10 years ago

Thanks for the great theme. I wanted an RSS feed and my own Google Analytics settings and added them in this pull request.

ssorallen commented 10 years ago

I can split these into separate pull requests if that's better.

mx3m commented 10 years ago

Great stuff!

Now for the selectors, I don't know. Can you submit a different pull request for this, if possible? I personally like to have my tag selectors as specific as possible to understand what I'm looking at. Maybe it's a bad habit?

ssorallen commented 10 years ago

I tend to use the least-specific selector that will match the elements I want. It leads to more reusable CSS and makes for easier overriding of styles down the line. That said, it does depend on personal preference; there's not really a wrong way to write CSS if it works.

I will remove the CSS changes out and create a new pull request.

mx3m commented 10 years ago

I know what you mean. For themes, in general, I tend to use specific selectors so it's easier for people to override my basic styles (in this case, I could have used #posts for something else than ul; EDIT: I just realised that what I'm saying doesn't make any sense... nevermind). But again, that might just be an old and bad habit =/

Thank you so much for contributing to this theme! Looking forward to your new pull request!